Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for building on centos7 and centos8 #81

Closed
wants to merge 1 commit into from

Conversation

quanah
Copy link
Contributor

@quanah quanah commented May 24, 2021

These changes enable me to build git-buildpackage on CentOS8 without any errors.

@quanah quanah force-pushed the centos8-fixes branch 3 times, most recently from bd44cdd to b3c0d55 Compare May 26, 2021 20:28
@quanah quanah changed the title Fixes for building on centos8 Fixes for building on centos7 and centos8 May 26, 2021
setup.py Outdated Show resolved Hide resolved
@agx
Copy link
Owner

agx commented May 27, 2021

Thanks! I Two nits above, if that's too much of a hazzle i can split it out when merging.

@quanah
Copy link
Contributor Author

quanah commented May 27, 2021

Done, let me know if there's anything further. :)

@agx
Copy link
Owner

agx commented May 28, 2021

@quanah I've merged the first bit but while testing i noticed that the new logic prefers docbook2man over docbook2x-man which breaks the doc build on Debian. Can you make the logic select docbook2x-man with highest preference (or at least let me know if that works for you too and doesn't break your Centos build right away again)

@quanah
Copy link
Contributor Author

quanah commented May 28, 2021

@quanah I've merged the first bit but while testing i noticed that the new logic prefers docbook2man over docbook2x-man which breaks the doc build on Debian. Can you make the logic select docbook2x-man with highest preference (or at least let me know if that works for you too and doesn't break your Centos build right away again)

Let me know if you like the new solution better. :)

@agx
Copy link
Owner

agx commented May 30, 2021

@quanah looks good, i've split things up a little (keeping your authorship) and pushed.

@agx agx closed this May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants