Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other keys should be disabled when modal is active #1

Closed
agzam opened this issue Aug 1, 2016 · 3 comments
Closed

Other keys should be disabled when modal is active #1

agzam opened this issue Aug 1, 2016 · 3 comments

Comments

@agzam
Copy link
Owner

agzam commented Aug 1, 2016

When a modal is active other keys (that have no dedicated action) should be disabled

@agzam
Copy link
Owner Author

agzam commented Oct 5, 2017

That may not be easily doable at the moment. See this: Hammerspoon/hammerspoon#1505

@jaidetree
Copy link
Collaborator

I think this one has been resolved already right?

@agzam
Copy link
Owner Author

agzam commented May 8, 2020

I think this one has been resolved already right?

No, it's not really resolved. What it originally meant is to disable all the keys except the ones that are available in the modal. The main reasoning was that modals used to "leak" their keys (e.g. if you press w in LEAD m modal, it would take you to LEAD w modal. Your amazing work on the state-machine has fixed that.

But I also wanted to protect the current app from responding to keys that are not present in the modal to avoid confusion on multi-monitor systems.

I think we can close this issue with a "won't fix" flag, it's not too annoying anymore, as it used to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants