When switching windows quickly, the yellow outline gets left behind

[tntmarket]

To Reproduce:

Switch back and forth between windows quickly
Video: https://gfycat.com/officialsnivelingemperorpenguin

Result: The yellow outline when switching focus stays, even after closing or moving the window

Workaround: Reload config in hammerspoon

My Computer:
Mac Version: 10.15.4
Hammerspoon Version: [0.9.78]
Spacehammer Version: 9c99680

Potential Duplicate: #9

[jaidetree]

Confirming error reproduction.

Current hypothesis:
While not seemingly related to #9 it seems to mirror #31 where after many, rapid uses it seems to stop working. The cause was the garbage collector cleaning up refs to the listeners that were not stored anywhere.

Possible fixes:

• Create a shared ref to the rectangle object the jump function sets so that there will never be more than 1 highlighted window and timer to clean up.
• Create a queue or stream of these events to clean up. May require an FRP stream library I'm drafting for fennel.

I'm going to give solution #1 a shot as that will be much faster to draft and test. Thanks for the detailed report.

[agzam]

@tntmarket Thank you for reporting it, and thank you @eccentric-j for addressing it so quickly. I am sorry folks for being very slow at approving and reviewing things. My team got furloughed due to COVID-19 crisis, and the job search occupies most of my time lately. I approved the PR and I hope we can merge the fix soon.