Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the initial history not tracked #155

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

HyunggyuJang
Copy link
Contributor

Currently, the history.push ignores initial window frame information.
Think it should be respected.

@agzam
Copy link
Owner

agzam commented Dec 17, 2021

It's been quite a while since the last time I touched that piece. Could you please explain the problem and the change? Functionally, I'm not seeing any difference between this and what's in master ¯\_(ツ)_/¯

@HyunggyuJang
Copy link
Contributor Author

HyunggyuJang commented Dec 17, 2021

For my use case, after doing some stuff with maximized window, usually, I’d like to see the ‘state’ before I jumped into the focused, maximized window.
Unfortunately, without this commit, if there were no window action triggered other than maximization for that window, I couldn’t get back to the before maximization.

Here, I used maximization action as an example, but will apply for the first actions to given window.

Copy link
Owner

@agzam agzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the explanation. Although, I still didn't quite get it, sorry. However, I have tested it - at least it doesn't appear to be breaking anything. Feel free to merge it anytime. Thank you!

@Grazfather
Copy link
Collaborator

Is this for undo? I don't really understand the use case either, and undo doesn't seem to work for me.

@Grazfather
Copy link
Collaborator

Actually, this helped me find a bug in my own config. We should probably be more careful with when we push.

@Grazfather Grazfather merged commit e0f649f into agzam:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants