New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project 1 list structure #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ahangarha ,
Status: Approved ✔️ ✔️ ✔️
✔️ Linters are passing
✔️ Dev server runs without any issues
✔️ Good commit messages
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Check the comments below for optional changes
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/index.html
Outdated
<body> | ||
<main id="todo-wrapper"> | ||
<div class="todo-header"> | ||
<h4>Title</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- (OPTIONAL) Consider replacing
Title
here withToday's To Do
as it is more explicit and it also follows the design 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
README.md
Outdated
## Live Demo | ||
|
||
Not available yet | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- (OPTIONAL) Since a live demo link is not available, it would be better to remove this section as it now serves no purpose in order to make the README file more professional 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
A message to the new reviewerI submitted wrong link to this PR. The last PR is this one: #2 |
Description
The first phase on making a Todo List web application.
General requirements
HTML/CSS requirements
Additional notes
Live Demo is not available since Github pages default action doesn't support such projects.
Thank you for taking the time to review this pull request.