Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project 2 add remove #2

Merged
merged 11 commits into from Feb 16, 2022
Merged

Project 2 add remove #2

merged 11 commits into from Feb 16, 2022

Conversation

ahangarha
Copy link
Owner

Description

In the second PR, these functionalities are added:

  • Add new todo
  • Modified todos
  • Remove todos
  • Remove all completed todos
  • Mark todo as completed
  • Store data in localStorage

General requirements

  • There are no linter errors.
  • Followed the Github flow.
  • The documentation is professional.

HTML/CSS requirements

  • Followed best practices for HTML & CSS
  • Followed best practices for JavaScript

Thank you for taking the time to review this pull request.

Copy link

@elyor-doniyorov elyor-doniyorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ahangarha,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Approved-d house

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@ahangarha ahangarha merged commit a74be6e into main Feb 16, 2022
@ahangarha ahangarha deleted the project-2-add-remove branch February 16, 2022 10:44
@ahangarha ahangarha mentioned this pull request Feb 16, 2022
5 tasks
Copy link

@Meltrust Meltrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ahangarha,

Wow, you did it 🎉

Brilliant

Note: This review was done in this PR because the student made a human mistake and sent the wrong link. Upon contacting him, the student directed me to this PR. It had been already merged. Performed review against project requirements as instructed by scr. Approving because it meets and also exceeds the project's requirements

To highlight:

  • Nice code organization✔️
  • Nice OOP implementation✔️
  • Nice use of CSS variables✔️
  • You exceeded the project requirements. I commend your extra effort 👏

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants