New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project 2 add remove #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ahangarha,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ahangarha,
Wow, you did it 🎉
Note: This review was done in this PR because the student made a human mistake and sent the wrong link. Upon contacting him, the student directed me to this PR. It had been already merged. Performed review against project requirements as instructed by scr. Approving because it meets and also exceeds the project's requirements
To highlight:
- Nice code organization✔️
- Nice OOP implementation✔️
- Nice use of CSS variables✔️
- You exceeded the project requirements. I commend your extra effort 👏
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Description
In the second PR, these functionalities are added:
General requirements
HTML/CSS requirements
Thank you for taking the time to review this pull request.