Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test part 1 #5

Merged
merged 6 commits into from Feb 22, 2022
Merged

Test part 1 #5

merged 6 commits into from Feb 22, 2022

Conversation

ahangarha
Copy link
Owner

Description

In this PR we have added test for

  • Adding one item to the todo list
  • Removing one items from the todo list

General requirements

  • There are no linter errors.
  • Followed the Github flow.
  • The documentation is professional.

HTML/CSS requirements

  • Followed best practices for HTML & CSS
  • Followed best practices for Javascript

Thank you for taking the time to review this pull request.

Copy link

@ReshyResh ReshyResh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

Great job with the tests, the app seems to be working just fine!

Your project is complete, you may now merge it!

Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form

@ahangarha ahangarha merged commit 5f826f0 into main Feb 22, 2022
@ahangarha ahangarha deleted the test-part-1 branch February 22, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants