Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test part 2 #6

Merged
merged 6 commits into from Feb 23, 2022
Merged

Test part 2 #6

merged 6 commits into from Feb 23, 2022

Conversation

ahangarha
Copy link
Owner

Description

To test the following functionalities:

  • Editing todo
  • Marking todo as completed
  • Removing all completed todos

General requirements

  • There are no linter errors.
  • Followed the Github flow.
  • The documentation is professional.

HTML/CSS requirements

  • Followed best practices for HTML & CSS
  • Followed best practices for JavaScript

Thank you for taking the time to review this pull request.

brahimdidi and others added 6 commits February 23, 2022 09:20
We forgot that we already have one todo in the list from the previous
test so actually what we are clicking and testing in this particular
test is not what we added in thie line but the todo which was added
before.

So this line has no effect and therefore can be removed.
Copy link

@TedLivist TedLivist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED ✔️ ✔️

Hi @ahangarha and @brahimdidi,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@ahangarha ahangarha merged commit c44889c into main Feb 23, 2022
@ahangarha ahangarha deleted the test-part-2 branch February 23, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants