Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make "mUpdateInterval" uint32_t #5

Open
wunditta opened this issue Jul 3, 2019 · 0 comments
Open

make "mUpdateInterval" uint32_t #5

wunditta opened this issue Jul 3, 2019 · 0 comments

Comments

@wunditta
Copy link

wunditta commented Jul 3, 2019

On some boards (e.g. ATmega like Uno) "int" is only 2 bytes and thus is capped unsigned at only roughly 65000. As mUpdateInterval holds milliseconds this more or less means that you can have 1 minute max as update interval.
I suggest to set the type of mUpdateInterval to uint32_t, which is always right.
electricant added a commit to electricant/EasyNTPClient that referenced this issue Apr 2, 2021
@electricant
Make mUpdateInterval uint32_t for better compatibity with differnet
6eaabe4 
hardware.

AS decribed in aharshac#5

On some boards (e.g. ATmega like Uno) "int" is only 2 bytes and thus is capped unsigned at only roughly 65000. As mUpdateInterval holds milliseconds this more or less means that you can have 1 minute max as update interval.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wunditta