Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save path and cwd in cache files #19

Closed
wants to merge 1 commit into from

Conversation

alexander-akait
Copy link

If use gulp-rename or other pipes for change path and cwd, we save source path and cwd. Resolve #18

If use gulp-rename or other pipes for change path and cwd, we save source path and cwd. Resolve ahaurw01#18
@ahaurw01
Copy link
Owner

Thanks for the PR. I hesitate to incorporate these changes for a few reasons.

  • Mutating the cached file's base and path will be a breaking change for some people.
  • If there's a desire to reintroduce the files as they were, and not how they have evolved, I think file.clone() is a better option. Maybe gulp-clone is a good step for you in your workflow.
  • The goal of this plugin (and all gulp plugins) is always to be simple. Build processes are most effective when complexity is avoided. I urge you again to look at removing complexity from your build process before introducing more into plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants