-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow null text option #3
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @bobbwhy, thanks for the pull request!
i appreciate you documenting the proposed feature in detail, as we can eventually re-use the proposal to be documentation for the new feature.
gave some feedback.
Currently, the cli prompter will not accept a null string as the entered | ||
value, but will instead simply repeat the prompt. | ||
|
||
This proposal would add an option, **allowNull** to each question object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about required
? would that support the same use case?
@@ -0,0 +1,4081 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure about committing package-lock.json
or yarn.lock
for a library repo, it adds git bloat and doesn't really provide any benefit when libraries are developed sparingly and you want the dependencies to match what a new user would experience (not what's in your lock file). thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Although I can see the value of a lock file in a company shipping a customer-facing app, I don't think it is necessary for libraries and their dependencies.
This proposal would add an option, allowNull to each question object
passed into a prompt.