Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display up vs total servers #73

Closed
aheart opened this issue Sep 25, 2019 · 6 comments
Closed

Display up vs total servers #73

aheart opened this issue Sep 25, 2019 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aheart
Copy link
Owner

aheart commented Sep 25, 2019

Add online status boolean to https://github.com/aheart/hearth/blob/master/src/metrics/aggregator.rs#L15
derive(Default) sets booleans to false so it's perfect for us.
On the frontend show {{up}}/{{total}} instead of just total.
Where up is the count of servers with online status boolean set to true.

@aheart aheart added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 25, 2019
@aheart aheart changed the title Display up vs total server Display up vs total servers Oct 1, 2019
@Thermatix
Copy link
Contributor

Thermatix commented Oct 1, 2019

I've created a PR for this -> #74 though I'm not sure how to actually set the online status for the struct on the sever, though I admit I haven't had too much time to go through the code and find it.

@aheart
Copy link
Owner Author

aheart commented Oct 1, 2019

@Thermatix, thank you for the PR! I've looked through the code, tested it and left a couple of comments. With several tweaks it should be good to go.

@Thermatix
Copy link
Contributor

Thermatix commented Oct 1, 2019

@aheart I don't see the comments

@aheart
Copy link
Owner Author

aheart commented Oct 1, 2019

Oh, sorry about that. I forgot to submit the review and the comments were only visible for me.

@Thermatix
Copy link
Contributor

@aheart changes made!

@aheart
Copy link
Owner Author

aheart commented Oct 2, 2019

Implemented in #74

@Thermatix thank you for your contribution!

@aheart aheart closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants