-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display up vs total servers #73
Comments
I've created a PR for this -> #74 though I'm not sure how to actually set the online status for the struct on the sever, though I admit I haven't had too much time to go through the code and find it. |
@Thermatix, thank you for the PR! I've looked through the code, tested it and left a couple of comments. With several tweaks it should be good to go. |
@aheart I don't see the comments |
Oh, sorry about that. I forgot to submit the review and the comments were only visible for me. |
@aheart changes made! |
Implemented in #74 @Thermatix thank you for your contribution! |
Add online status boolean to https://github.com/aheart/hearth/blob/master/src/metrics/aggregator.rs#L15
derive(Default) sets booleans to false so it's perfect for us.
On the frontend show {{up}}/{{total}} instead of just total.
Where up is the count of servers with online status boolean set to true.
The text was updated successfully, but these errors were encountered: