Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/up vs total #74

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Feature/up vs total #74

merged 2 commits into from
Oct 2, 2019

Conversation

Thermatix
Copy link
Contributor

  • I've added the attribute online to the NodeMetrics struct
  • I've added javascript to then display the number of up machines with updateUpVsTotal()
  • I've refactored updateChart() to use a generic updateAggregateMetric()

src/metrics/aggregator.rs Show resolved Hide resolved
src/metrics/aggregator.rs Outdated Show resolved Hide resolved
static/index.html Outdated Show resolved Hide resolved
@Thermatix Thermatix force-pushed the feature/up_vs_total branch 5 times, most recently from 519d33d to e467462 Compare October 1, 2019 21:29
@coveralls
Copy link

coveralls commented Oct 1, 2019

Pull Request Test Coverage Report for Build 213

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 45.175%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/metrics/aggregator.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 204: -0.06%
Covered Lines: 323
Relevant Lines: 715

💛 - Coveralls

@aheart
Copy link
Owner

aheart commented Oct 2, 2019

@Thermatix thank you for the prompt adjustments. 👍 I see two fixup commits. Are you ok with me using githubs "Rebase and Merge" feature or would you prefer to rebase the branch yourself?

@Thermatix
Copy link
Contributor Author

Thermatix commented Oct 2, 2019

@aheart I can do it, I just wanted to wait to make sure it was ok with you first as I know how rebasing can be.

EDIT:

Just rebased it.

@aheart aheart merged commit df0caa3 into aheart:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants