Add support for thumbnail #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yeah looks good. I merged the addition. we still need to document their differences and that graphicsmagick doesn't support this method. its would be great if you could write up something quick. all the docs are in the gh-pages branch. thanks again! |
|
Actually it does. Yup, I'll send another PR soon with the docs. |
|
oh nice! thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the helper
.thumbfirst performs a.size, computes crop dimensions, and then crops and resizes the image.I want to generate thumbnails but tried to avoid this two-pass method. I bumped into a superuser question which uses the
-thumbnailoption, but this is not available in gm.This pull requests extends args with support for thumbnail, includes a simple test, and an example. I reckon thumbnail might conflict with thumb in a naming sense, but its the official name.