Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Your timezone Get Server TimeZone #49

Merged
merged 4 commits into from
Jan 27, 2024
Merged

Conversation

amrmostafa800
Copy link
Contributor

fix #48

@ahelmy
Copy link
Owner

ahelmy commented Jan 27, 2024

Thank you @amrmostafa800, we should apply the same approach in all time apis

@amrmostafa800
Copy link
Contributor Author

please check now

@codecov-commenter
Copy link

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (775f316) 93.17% compared to head (ac2e316) 91.25%.

Files Patch % Lines
internal/time.go 42.85% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   93.17%   91.25%   -1.93%     
==========================================
  Files          24       24              
  Lines         542      560      +18     
==========================================
+ Hits          505      511       +6     
- Misses         26       38      +12     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahelmy ahelmy merged commit 42d5040 into ahelmy:main Jan 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time converter 'Your timezone' isn't correct
3 participants