馃巸 #HackTober - add tests for bitcoin prices 馃巸 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherd2985
approved these changes
Oct 10, 2020
This was
linked to
issues
Oct 10, 2020
aherd2985
added
enhancement
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃尳 Adds error handling for BitcoinPrices
馃懟 Adds null check for BitCoinPrices
馃嵃 Adds interface in front of WebClient which can be used to mock any calls to WebClient and 'just works'
馃嵑 Adds tests for BitCoinClient