Sagemath cython3 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please squash the |
tornaria
force-pushed
the
sagemath-cython3
branch
from
9b28949
to
478c964
Compare
|
I had messed up the patches. Since the PRs sagemath/sage#36109 and sagemath/sage#36110 are based on sagemath 10.2.beta0 and we want to apply on 10.1, I added a couple of small "pre-patches" which make it so that those PRs apply cleanly. Hopefully now everything is ok. |
ahesford
force-pushed
the
python3-Cython-3.0.0
branch
5 times, most recently
from
b5700c5
to
53461a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
@ahesford Here's a first attempt to sagemath in cython3. Seems quite promising.
Second commit is just cherry-pick from void-linux#45708, which is mostly ready to go.
Third commit adds a patch to cysignals to avoid a warning (there are more warnings IIRC, but this is the only one which "leaks" to other packages since it is in a .pxd file).
There is a minor issue which is that cython version is hardcoded to 3.0.0 in a few doctests so they will fail in our current 3.0.2 (see sagemath/sage#36110 (comment)) but that will surely be fixed soon in sagemath/sage#36110.