Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypy 7.1 호환 - bytes/unicode 비교를 제거하고 발생하지 않는 None을 narrow합니다 #22

Merged
merged 2 commits into from
Mar 31, 2024

Conversation

youknowone
Copy link
Member

#18 에서 확인된 빌드 오류

@puzzlet
Copy link
Member

puzzlet commented Mar 31, 2024

컴파일은 되지만 실행시키면 오류가 납니다:

$ echo '' | ./rpaheui-c -c -
RPython traceback:
  File "aheui_aheui.c", line 637, in entry_point
  File "aheui_aheui.c", line 3158, in mainloop
Fatal RPython error: ValueError
Aborted (core dumped)

소스를 열어 보면 mainloop 전체가 날아가 있고 raise ValueError만 남아 있습니다.

// /tmp/usession-release-pypy2.7-v7.3.15-34/testing_1/aheui_aheui.c

Signed pypy_g_mainloop(struct pypy_aheui_aheui_Program0 *l_program_0, struct pypy_aheui_compile_Debug0 *l_debug_0) {
    Signed l_v4253;

    /* block0: (inlined) */
    pypy_g_RPyRaiseException((&pypy_g_exceptions_ValueError_vtable.ve_super.se_super.e_super), (&pypy_g_exceptions_ValueError.ve_super.se_super.e_super));
    PYPY_DEBUG_RECORD_TRACEBACK("mainloop");
    l_v4253 = -1L;
    /* block1: (inlined) */
    RPY_DEBUG_RETURN();
    return l_v4253;
}

JIT을 끄면 정상적으로 동작하는 것으로 봐서 뭔가 JIT 사용법이 바뀐 것 같습니다.

@youknowone youknowone changed the title pypy 7.3 호환 - bytes/unicode 비교를 제거하고 발생하지 않는 None을 narrow합니다 pypy 7.1 호환 - bytes/unicode 비교를 제거하고 발생하지 않는 None을 narrow합니다 Mar 31, 2024
@youknowone
Copy link
Member Author

7.3에서는 ValueError이고 7.1에서는 정상 동작하는걸 보니 jit은 이후에 또 따로 바뀌었나보네요.

@youknowone youknowone force-pushed the pypy-build branch 2 times, most recently from e5705f3 to 1a295b6 Compare March 31, 2024 17:59
@youknowone
Copy link
Member Author

jit는 v7.3.13까지는 동작하는걸로 확인했습니다. JIT 관련은 따로 이슈 만들어둘게요

bytes/unicode 비교를 제거하고 발생하지 않는 None을 narrow합니다
@youknowone youknowone merged commit 1e5f483 into main Mar 31, 2024
1 of 2 checks passed
@youknowone youknowone deleted the pypy-build branch March 31, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants