Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow extends over rounded corner #40

Open
Eckelf opened this issue Jun 6, 2022 · 2 comments
Open

Arrow extends over rounded corner #40

Eckelf opened this issue Jun 6, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@Eckelf
Copy link

Eckelf commented Jun 6, 2022

Hi,

after running the example app and trying out the standard showroom I've noticed the following:
Standard arrow

The arrow extends over the rounded corner. Looking at the code it is supposed to be fixed by using an "arrowSidePadding" but I guess something isn't working correctly?
I also see this issue when I integrate it into my app.

When changing the padding to 2.0 from 1.8 the issue is fixed. Maybe something has changed in the layout at some point?

Version: 1.3.2
Xcode 13.4
iOS 15.5

@aheze
Copy link
Owner

aheze commented Jun 7, 2022

Indeed, when I was making this template I ran into the exact same problem, hardcoding a padding of 1.8...

Screen Shot 2022-06-06 at 9 10 29 PM

Not sure what I might have changed to cause this, I'll investigate. Maybe a device size issue?

@aheze aheze added the bug Something isn't working label Jun 7, 2022
@ConfusedVorlon
Copy link

ConfusedVorlon commented Aug 28, 2022

Just noting that I found exactly the same bug using Popovers on iOS 15.5
Adjusting the arrowSidePadding fixed the issue for me

2.1 seems to be about the minimum for me - though I think it looks better with a slightly larger padding

(note - I'm using the default corner radius)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants