Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweet Block #4 Validation Errors #13

Closed
ahmadawais opened this issue Dec 10, 2017 · 1 comment
Closed

Tweet Block #4 Validation Errors #13

ahmadawais opened this issue Dec 10, 2017 · 1 comment
Labels
bug enhancement

Comments

@ahmadawais
Copy link
Owner

ahmadawais commented Dec 10, 2017 •
edited
Loading

Since the Gutenberg plugin is continuously evolving, week after week, some code potentially goes stale like what happened here.

Currently, there is new validation API which is causing issues with the Tweet Block.
I figure it must be this file https://github.com/WordPress/gutenberg/blob/db507cd/blocks/api/validation.js

One of the demo tweet blocks I had built it now renders corrupted.
image

With this log message

image

Whereas I have myself changed the href in save: part of wp.blocks.registerBlockType API.
E.g.

Code present here.

Looking forward!
@ahmadawais ahmadawais mentioned this issue Dec 10, 2017
Closed
@ahmadawais
Copy link
Owner Author

This repository is depreciated in favor of create-guten-block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahmadawais