馃悰 FIX: error message for countries not found or without cases #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API must have been down when you ran that query. The Before one. Can you share exact command you ran to get that? |
|
@ahmadawais the API wasn't down then. I even successfully ran other commands. There was a slight error in the code that handles catching error for countries not found(404 case) and that was what I fixed. Nothing much. The command I ran was |
|
Thank you for this. :) 馃敆 https://github.com/ahmadawais/corona-cli/releases/tag/5.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error message for countries not found or without cases
Initially, when users input countries that don't exist or without cases, they get an "API down message". But this has been corrected. View screenshots below
Before:
After:
