Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace _lookupFactory() with factoryFor() #117

Merged
merged 1 commit into from Apr 1, 2017
Merged

Replace _lookupFactory() with factoryFor() #117

merged 1 commit into from Apr 1, 2017

Conversation

gregjopa
Copy link
Contributor

@gregjopa gregjopa commented Apr 1, 2017

This fixes #112

@gregjopa gregjopa mentioned this pull request Apr 1, 2017
Closed
@gregjopa
Copy link
Contributor Author

gregjopa commented Apr 1, 2017

Tests are all green 😄

@gregjopa gregjopa merged commit ed1f9c7 into ahmadsoe:master Apr 1, 2017
@gregjopa
Copy link
Contributor Author

gregjopa commented Apr 3, 2017

@ahmadsoe can you please release version 0.5.4?

@ahmadsoe
Copy link
Owner

ahmadsoe commented Apr 4, 2017

@gregjopa done.

@gregjopa
Copy link
Contributor Author

gregjopa commented Apr 5, 2017

Thanks! I can confirm that 0.5.4 removes the deprecation message for _lookupFactory with Ember 2.12.

@gregjopa gregjopa deleted the lookup-factory branch April 12, 2017 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DEPRECATION: Using "_lookupFactory"
2 participants
@gregjopa @ahmadsoe