Added an ability to use Highstock and Highmaps #9
Conversation
The addon no longer automatically imports the Highcharts Bower package, letting user import desired package manually
| "devDependencies": { | ||
| "highcharts-release": "~4.0.4" | ||
| "qunit": "~1.17.1", | ||
| "highstock-release": "~2.1.3" |
There was a problem hiding this comment.
Did you mean to leave this in as a dependency? Or should users explicitly add the package(s) they want?
There was a problem hiding this comment.
This is necessary for building the demo and running tests. It doesn't get into users' apps.
|
@lolmaus can we make the installation process more simple? leave the charts as default, and if users want highstock or highmaps they just need to put some config on Brocfile or enviroment.js. |
|
@ahmadsoe, we can have But importing the Bower package is a problem. If we let To mitigate that we'll have to introduce some kind of configuration variable accessible from the Node side of Ember CLI. I am not familiar enough with Ember CLI to do that. And i believe having a I'm not trying to press you, but if you don't accept this, i'm gonna publish my fork as a separate package. I will of course use a different package name and leave proper credit in the readme.
I hate community splits, so i would prefer to work in your package. Can you please accept this PR, sacrificing some installation convenience? And then, when somebody figures out how to conditionally import a Bower package, they do another PR restoring the convenience? |
|
Who says I am not gonna merge this? This is a good start to including highstocks and highmaps components on this addon. |
Added an ability to use Highstock and Highmaps
|
Merged.. thanks @lolmaus |
Fixes #2.
I have removed addBowerPackageToProject('highcharts-release#~4.0.4') and app.import(app.bowerDirectory + '/highcharts-release/highcharts.js');.
It is up to user whether to import Highcharts, Highstock and/org Highmaps, which are distributed from separate repos. I have added instructions to the readme.