Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a home page to be redirected to after login #9

Open
2 tasks
ahmeddrawy opened this issue Oct 15, 2020 · 7 comments · May be fixed by #11
Open
2 tasks

Make a home page to be redirected to after login #9

ahmeddrawy opened this issue Oct 15, 2020 · 7 comments · May be fixed by #11
Assignees
Labels
enhancement New feature or request frontend hacktoberfest help wanted Extra attention is needed

Comments

@ahmeddrawy
Copy link
Owner

  • make a static home page to view courses

  • use /api/courses endpoint to fetch courses from database and view them dynamically on home page

@ahmeddrawy ahmeddrawy added enhancement New feature or request help wanted Extra attention is needed labels Oct 15, 2020
@ahmeddrawy ahmeddrawy added this to the second release milestone Oct 15, 2020
@emma-r-slight
Copy link

I'd like to give this a go..... :)

@ahmeddrawy
Copy link
Owner Author

@emma-r-slight thank you, please make it dynamic and any meta data you want to add to course model or user model please let me know, I'll assign you

@emma-r-slight
Copy link

emma-r-slight commented Oct 17, 2020

Do you have any preference for a template(view) engine? express-handlebars, pug, dots.....? What information do you want to be listed from the course routes? Do you want just a list with name and tags, do you want to include an external link to the course?

@ahmeddrawy
Copy link
Owner Author

I was thinking about ejs but never used it, also I was planning to learn React
As a first step we can show their names and tags maybe we can edit the model too to add photos or another metadata
What do you think?

@emma-r-slight
Copy link

emma-r-slight commented Oct 18, 2020

Ok, I have used express handlebars before, which is quite a good stepping stone to react. It separates parts of the page into components similar to React.

For the courses I was looking at the Udemy page, it looks like there's an image( at this point I don't think it needs to be saved in the db, just use a random image from unsplash.com), Title, name of creater and then topic(tags).

Do you have a problem if I add some tests using Jest?

@ahmeddrawy
Copy link
Owner Author

ahmeddrawy commented Oct 18, 2020

Do you have a problem if I add some tests using Jest?

No, I know jest and was planning to have tests but i don't know how until now and will we apply unit or integration testing, what do you think ?

@emma-r-slight
Copy link

emma-r-slight commented Oct 18, 2020

At this point unit testing, I haven't used Nosql databases before (only SQL Databases) so wanted to write tests for the 'courses' db and api route.
This is a great article about testing 'login' if you were interested. It shows how to setup a Mongodb.config file for testing

@ahmeddrawy ahmeddrawy linked a pull request Oct 20, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants