Landing page #11

emma-r-slight · 2020-10-18T07:40:53Z

HI this isn't finished (obviously) just thought i'd push this up so you can see what i've been doing, i have refactored some of the file names. This is to take advantage of how index.js works in directories, also so you don't have lines and lines of imports/requires from a directory. I also separated concerns out of the app/index start file for the server, so all it does is set the local host.

I'm using Bootstrap 4 for css if thats alright, happy to use something else if you have a preferred CSS framework.

…landing-page

ahmeddrawy · 2020-10-20T16:21:40Z

startup/db.js

I'm setting the db URL here as a constant but i was planning to make it as environment variable later

I'm using express-async-errors package to handle errors like this one here

You used callback function to handle the connection result but the error is already handled by the error middleware and everything is logged using Winston package

I understand what you are saying, but for some reason, this is not connecting to the db. The winston logging is great, and very handy!! I'll see if i can resolve this problem... any suggestions to incorporate winston? (the change i made to this file connected to mongodb)

honestly I don't get you, can you elaborate for me

previously the way the file was set up there was no connection being made to the local mongoDB. The way i had rewritten the file connected to the local database so data was being added and could be retrieved from the mongoDB file.
I have now changed the code back to how you had it, removing the export function and adding "useCreateIndex: true".

The connection is now working to mongodb and a message is being added to the logfile.

ahmeddrawy · 2020-10-20T16:22:59Z

startup/index.js

@@ -0,0 +1,30 @@
+const express = require('express')


I have exactly the same code but in routes.js why you changed the file name ?

using index.js inside a directory means that you only need to require the directory name when importing the module.

eg: const app = require('../startup')

instead of

const app = require("../startup/routes")

I figured this out and found it quite useful thank you

ahmeddrawy · 2020-10-20T16:43:14Z

the app crashes with me giving

internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module './website/login'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/tle23/side-projects/nodejs/rest-api/routes/index.js:5:15)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/tle23/side-projects/nodejs/rest-api/startup/index.js:4:57)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
[nodemon] app crashed - waiting for file changes before starting

startup/db.js

ahmeddrawy · 2020-10-20T17:13:26Z

the app crashes with me giving

internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module './website/login'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/tle23/side-projects/nodejs/rest-api/routes/index.js:5:15)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/tle23/side-projects/nodejs/rest-api/startup/index.js:4:57)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
[nodemon] app crashed - waiting for file changes before starting

resolved by fixing routes/index.js requires

into landing-page

emma-r-slight · 2020-10-22T06:39:47Z

Hi,
localhost:8080/ - will render the top nav bar and the hero banner

localhost:8080/api/courses/seed = will seed the database with courses

localhost:8080/api/courses - will render with the courses listed

Do you want to ba able to see the courses only after you have logged in? Or do you want to see them on the home page and only be able to add new courses or edit courses once you are logged in??

ahmeddrawy · 2020-10-22T13:33:55Z

models/course.js

@@ -19,11 +20,16 @@ const schema = new mongoose.Schema({
    },
  },
 })
-module.exports = mongoose.model('Course', schema)
+


I don't get the point why you write the same code I've written before in a different style ?

ahmeddrawy · 2020-10-22T13:35:26Z

models/course.js

 function validateCourse(course) {
  const schema = Joi.object({
    name: Joi.string().min(3).required(),
    tags: Joi.array(),
  })
  return schema.validate(course)
 }
+
+exports.validate = validateCourse


is this a kind of easier way or just a typo ?

ahmeddrawy · 2020-10-28T11:12:58Z

Hi,
localhost:8080/ - will render the top nav bar and the hero banner
It doesn't load anything

localhost:8080/api/courses - will render with the courses listed

Do you want to ba able to see the courses only after you have logged in? Or do you want to see them on the home page and only be able to add new courses or edit courses once you are logged in??

This is what I get and all buttons doesn't work ? does it work with you or should I fix it myself ?

localhost:8080/api/courses/seed = will seed the database with courses

This - I don't know why - crashes the app

should I implement the login logic by saving the token to cookies

emma-r-slight added 6 commits October 18, 2020 18:15

refactor/rename files code to simplify file access

ea17013

setup views and base home page

549fb8e

Merge branch 'master' of https://github.com/ahmeddrawy/my-udemy into …

e589b33

…landing-page

setup views for landing page

78ac663

fix logging for program

369374f

set up view engine for handlebars

a4d6f64

ahmeddrawy requested changes Oct 20, 2020

View reviewed changes

ahmeddrawy reviewed Oct 20, 2020

View reviewed changes

startup/db.js Outdated Show resolved Hide resolved

ahmeddrawy linked an issue Oct 20, 2020 that may be closed by this pull request

Make a home page to be redirected to after login #9

Open

2 tasks

ahmeddrawy added hacktoberfest help wanted Extra attention is needed labels Oct 20, 2020

ahmeddrawy and others added 12 commits October 20, 2020 19:58

fix views path to render pages

a092aed

fix a typo in login route path

0bd493e

refactor/rename files code to simplify file access

f9a41ea

setup views and base home page

dbab167

setup views for landing page

7d1718a

fix logging for program

bd9fbd9

set up view engine for handlebars

0a48a7a

move views folder to startup folder

4d5d175

landing page: render courses on home page

b79ea2c

Merge branch 'landing-page' of https://github.com/emma-r-slight/my-udemy

ede8df9

into landing-page

edit style

cf54b56

change names and functions back to original settings

099f57d

ahmeddrawy reviewed Oct 22, 2020

View reviewed changes

enable connection to db and logging with winston

a04075b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Landing page #11

Landing page #11

emma-r-slight commented Oct 18, 2020

ahmeddrawy Oct 20, 2020

emma-r-slight Oct 22, 2020 •

edited

Loading

ahmeddrawy Oct 22, 2020

emma-r-slight Oct 23, 2020

ahmeddrawy Oct 20, 2020

emma-r-slight Oct 22, 2020

ahmeddrawy Oct 22, 2020

ahmeddrawy commented Oct 20, 2020

ahmeddrawy commented Oct 20, 2020

emma-r-slight commented Oct 22, 2020

ahmeddrawy Oct 22, 2020

ahmeddrawy Oct 22, 2020

ahmeddrawy commented Oct 28, 2020

Landing page #11

Are you sure you want to change the base?

Landing page #11

Conversation

emma-r-slight commented Oct 18, 2020

Choose a reason for hiding this comment

emma-r-slight Oct 22, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ahmeddrawy commented Oct 20, 2020

ahmeddrawy commented Oct 20, 2020

emma-r-slight commented Oct 22, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ahmeddrawy commented Oct 28, 2020

emma-r-slight Oct 22, 2020 •

edited

Loading