#1404 Code improvement

ahmedkaludi · Nov 16, 2017 · a7ac927 · a7ac927
1 parent c1f6104
commit a7ac927
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/accelerated-moblie-pages.php b/accelerated-moblie-pages.php
@@ -80,6 +80,7 @@ function ampforwp_get_the_page_id_blog_page(){
 
 // Add Custom Rewrite Rule to make sure pagination & redirection is working correctly
 function ampforwp_add_custom_rewrite_rules() {
+	global $redux_builder_amp;
     // For Homepage
     add_rewrite_rule(
       'amp/?$',
@@ -176,6 +177,10 @@ function ampforwp_add_custom_rewrite_rules() {
 	    );
 	  }
 	}
+	// For OneSignal
+	if(isset($redux_builder_amp['ampforwp-web-push-onesignal']) && $redux_builder_amp['ampforwp-web-push-onesignal'] ){
+		add_rewrite_rule('OneSignalSDKWorker.js','wp-content/plugins/accelerated-mobile-pages/includes/onesignal-integration/OneSignalSDKWorker.js','top');
+	}
 }
 add_action( 'init', 'ampforwp_add_custom_rewrite_rules' );
 

diff --git a/templates/features.php b/templates/features.php
@@ -4916,13 +4916,6 @@ function ampforwp_onesignal_notifications_styling(){
 <?php }
 	}	
 }
-// Rewrite Rule for Onesignal Service worker to make it work properly
-add_action( 'init', 'ampforwp_custom_rewrite_rule_onesignal' );
-if( ! function_exists('ampforwp_custom_rewrite_rule_onesignal')){
-	function ampforwp_custom_rewrite_rule_onesignal(){
-	 add_rewrite_rule('OneSignalSDKWorker.js','wp-content/plugins/accelerated-mobile-pages/includes/onesignal-integration/OneSignalSDKWorker.js','top');
-	}
-}
 // 95. Modify menu link attributes for SiteNavigationElement Schema Markup #1229 #1345
 add_filter( 'nav_menu_link_attributes', 'ampforwp_nav_menu_link_attributes', 10, 3 );
 if( ! function_exists( 'ampforwp_nav_menu_link_attributes' ) ) {