Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-wistia--player support #1875

Closed
ahmedkaludi opened this issue Mar 15, 2018 · 8 comments
Closed

amp-wistia--player support #1875

ahmedkaludi opened this issue Mar 15, 2018 · 8 comments
Assignees
@MARQAS
Labels
NEXT UPDATE
Milestone
W14

Comments

@ahmedkaludi
Copy link
Owner

No description provided.

@ahmedkaludi ahmedkaludi added this to the W10 milestone Mar 16, 2018
@MARQAS
Copy link
Contributor

MARQAS commented Mar 23, 2018 •
edited by MohammedKaludi

https://secure.helpscout.net/conversation/541913202/23184?folderId=1060556

and updated:
https://secure.helpscout.net/conversation/522216130/21577/?folderId=1060554

@MARQAS
Copy link
Contributor

MARQAS commented Mar 23, 2018

Let's see how our user is embedding it to properly implement it.

@MohammedKaludi MohammedKaludi modified the milestones: W10, W11 Mar 28, 2018
@emma-tuna
Copy link

Hello, I would just like to say that this is a very important issue to me. I am also looking to embed wistia videos. If I can help in any way, let me know. :)

@ansaritalha
Copy link
Contributor

https://secure.helpscout.net/conversation/555969522/24161?folderId=1914716

@ahmedkaludi ahmedkaludi modified the milestones: W11, To Do Apr 16, 2018
@mdkaleem95
Copy link

Need to make the support of Wistia player and below you will find the embed code.

Wistia Embed Code: https://pastebin.com/sBMBeuiz

Ref: https://secure.helpscout.net/conversation/522216130/21577/

@ahmedkaludi ahmedkaludi modified the milestones: To Do, W13 May 21, 2018
@mdkaleem95 mdkaleem95 modified the milestones: W13, W14 Jun 6, 2018
@MARQAS
Copy link
Contributor

MARQAS commented Jun 18, 2018

Hi @emma-tuna, Can you tell us how are you embedding wistia videos? Can you share a code snippet and a link where you are adding the wistia videos?

MARQAS added a commit that referenced this issue Jun 18, 2018
@MARQAS
#1875 amp-wistia-player embed handler added
fe6c445
MARQAS added a commit that referenced this issue Jun 18, 2018
@MARQAS
#1875 Remove unnecesarry wistia code
4ef52bb
@MARQAS
Copy link
Contributor

MARQAS commented Jun 18, 2018

Working at the user end as well. just need to check the styling of player

MARQAS added a commit that referenced this issue Jun 19, 2018
@MARQAS
#1875 amp-wistia-player styling added
58b9850
MARQAS added a commit that referenced this issue Jun 20, 2018
@MARQAS
#1875 wistia support improvement
4af9865
@MohammedKaludi
Copy link
Collaborator

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MARQAS MARQAS

Labels
NEXT UPDATE
Projects
None yet
Milestone
W14
Development

No branches or pull requests
6 participants
@emma-tuna @MARQAS @ahmedkaludi @MohammedKaludi @mdkaleem95 @ansaritalha