Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMP Take over is applying even on product when this option is enabled only for posts. #2304

Closed
ghost opened this issue Jul 2, 2018 · 3 comments
Closed

AMP Take over is applying even on product when this option is enabled only for posts. #2304

ghost opened this issue Jul 2, 2018 · 3 comments
Assignees
@Zabi09
Milestone
W15

Comments

@ghost
Copy link

ghost commented Jul 2, 2018

REF: https://secure.helpscout.net/conversation/609140913/28874/?folderId=1680011

Steps to recreate the issue:
1)Enable the AMP take over only on Posts.
2)Disable the AMP on Pages and Archives
3)There should be no AMP woocommerce plugin.

Note: Whoever is working on this ticket please notify the customer that in which update version this issue is going to be fixed.
@ahmedkaludi ahmedkaludi added this to the W15 milestone Jul 2, 2018
@ahmedkaludi ahmedkaludi modified the milestone: W15 Jul 2, 2018
Zabi09 added a commit that referenced this issue Jul 5, 2018
@Zabi09
#2304 enable AMP takeover only when selected in CPT
bc67209
Zabi09 added a commit that referenced this issue Jul 6, 2018
@Zabi09
#2304 redirection condition improved for blog page
aee05d8
@MohammedKaludi
Copy link
Collaborator

👍 ready to be pushed.

@MohammedKaludi MohammedKaludi added ready and removed bug labels Sep 6, 2018
Zabi09 added a commit that referenced this issue Sep 17, 2018
@Zabi09
#2304 enable AMP takeover only when selected in CPT and added in master
83ed177
@MohammedKaludi
Copy link
Collaborator

👍 can be pushed in 0.9.97.16

@Omair52
Copy link
Contributor

Omair52 commented Sep 19, 2018

Pushed in 0.9.97.16

@Omair52 Omair52 closed this as completed Sep 19, 2018
@ghost ghost removed the ready label Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zabi09 Zabi09

Labels
None yet
Projects
None yet
Milestone
W15
Development

No branches or pull requests
5 participants
@ahmedkaludi @MohammedKaludi @Sejiro-Hiko @Zabi09 @Omair52