Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude post part Big issue : Posts that should not have AMP get showed as AMP #241

Closed
khaledMohammed000 opened this issue Nov 29, 2016 · 4 comments

Comments

@khaledMohammed000
Copy link
Contributor

https://wordpress.org/support/topic/some-issues-with-plugin/#post-8494214

Video : http://take.ms/yLWKf

@MohammedKaludi
Copy link
Collaborator

right, the post who's amp version is deactivated, should also be excluded from amp.

Possible solution: We can save the value in meta field and get the post ID and exclude the posts from the loop.

@khaledMohammed000 khaledMohammed000 added this to the 0.9.1 Version milestone Dec 9, 2016
@MohammedKaludi MohammedKaludi changed the title Big issue : Posts that should not have AMP get showed as AMP Exclude post part Big issue : Posts that should not have AMP get showed as AMP Dec 9, 2016
khaledMohammed000 added a commit that referenced this issue Dec 10, 2016
More changes are required
@ahmedkaludi
Copy link
Owner

The code was a bit mess, so had to revert:

@ahmedkaludi
Copy link
Owner

We're removing this from the milestone for now.

@ahmedkaludi ahmedkaludi removed this from the 0.9.1 Version milestone Dec 15, 2016
@khaledMohammed000
Copy link
Contributor Author

@ahmedkaludi ok .... I had @MohammedKaludi Bhai's permission to mess up that code....He said he would fix that issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants