Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To make the Compatibility with Gutenberg #2427

Closed
merajali294 opened this issue Aug 4, 2018 · 15 comments
Closed

To make the Compatibility with Gutenberg #2427

merajali294 opened this issue Aug 4, 2018 · 15 comments
Assignees
@MARQAS
Labels
feature
Milestone
Wave

Comments

@merajali294
Copy link
Contributor

merajali294 commented Aug 4, 2018 •
edited
Loading

https://wordpress.org/support/topic/gutenberg-wordpress-5-0-is-not-far-away/

GutenBurg:

https://wordpress.org/plugins/gutenberg/
@merajali294 merajali294 changed the title To make the Compatibility with To make the Compatibility with Gutenberg Aug 4, 2018
@merajali294 merajali294 added this to the W15 milestone Aug 4, 2018
MARQAS added a commit that referenced this issue Aug 14, 2018
@MARQAS
#2427 Gutenberg compatibility
93147eb
@MohammedKaludi
Copy link
Collaborator

breaking the category module, converting it to the gallery.

The code is applying everywhere, this should only effect on Gutenberg modules.

MARQAS added a commit that referenced this issue Aug 20, 2018
@MARQAS
#2427 Change only in Gutenberg Gallery module
36bf6fc
@MohammedKaludi
Copy link
Collaborator

@MARQAS as we have added files in vendor folder. Need to update the vendor log.

@ahmedkaludi ahmedkaludi self-assigned this Sep 27, 2018
@MohammedKaludi
Copy link
Collaborator

What can we do to get the styling?

NON-AMP: http://take.ms/y5d1q
AMP without Styling: http://take.ms/kZTAF

In the amp, Unicorn image is loading on the page, but because it is not getting the stylings, the Block is not loading. Block is called "Cover Image". http://take.ms/H36o0

MARQAS added a commit that referenced this issue Dec 11, 2018
@MARQAS
#2427 #2719 Styling for cover image added and vendor changelog updated
98a194c
@MARQAS MARQAS mentioned this issue Dec 11, 2018
Closed
@MARQAS MARQAS modified the milestones: W15, Wave Dec 11, 2018
MARQAS added a commit that referenced this issue Dec 14, 2018
@MARQAS
#2427 Files updated To make the gallery work with lightbox option
91b77d4
@pegazee
Copy link
Contributor

pegazee commented Dec 18, 2018 •
edited
Loading

The "cover image" block is working on my end but the shadow on the images is not loading properly on AMP.

Screenshots:
non-amp > http://take.ms/oPKLl
amp > http://take.ms/rzeeS

@pegazee
Copy link
Contributor

pegazee commented Dec 18, 2018 •
edited by mdkaleem95
Loading

** REVIEW **

  • Kaleem

  • Imran

  • Talha

Zabi09 added a commit that referenced this issue Dec 19, 2018
@Zabi09
#2427 added image alignment in gutenberg
f10ed34
MARQAS added a commit that referenced this issue Dec 22, 2018
@MARQAS
#2427 Cover image CSS
4f90818
@pegazee
Copy link
Contributor

pegazee commented Dec 22, 2018 •
edited by syedimran22
Loading

** REVIEW **

  • Kaleem

  • Imran

  • Talha

@mdkaleem95
Copy link

Cover Image Issue
Master: http://take.ms/iwpcAq
Beta: http://take.ms/JkMwr

@mdkaleem95 mdkaleem95 removed their assignment Jan 5, 2019
@syedimran22
Copy link
Contributor

Cover Image is getting zoom-in compared to the non-amp cover image.

@syedimran22 syedimran22 removed their assignment Feb 14, 2019
@MARQAS
Copy link
Contributor

MARQAS commented Feb 26, 2019

It is working as expected.
@beingsmart3 @syedimran22, we have not yet added this ticket in the master

@MohammedKaludi
Copy link
Collaborator

Page Breaking with Gutenberg.

@MARQAS
Copy link
Contributor

MARQAS commented Mar 14, 2019

Can you check again @MohammedKaludi?

@MohammedKaludi
Copy link
Collaborator

gallery throwing validation errors
https://monosnap.com/file/zg7MnPFWy1X9oOtD7iy5TcIvMe1Gm6

MARQAS added a commit that referenced this issue May 11, 2019
@MARQAS
#2427 It was missing in master
42faf4d
@MARQAS
Copy link
Contributor

MARQAS commented May 11, 2019

It is working as expected on my end, can you share the content which you are trying to add?

@MohammedKaludi
Copy link
Collaborator

👍 ready to merge.

MARQAS added a commit that referenced this issue May 13, 2019
@MARQAS
#2427 Added in master
87c64b4
@MohammedKaludi
Copy link
Collaborator

Pushed in 0.9.97.52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MARQAS MARQAS

Labels
feature
Projects
None yet
Milestone
Wave
Development

No branches or pull requests
8 participants
@MARQAS @ahmedkaludi @MohammedKaludi @pegazee @mdkaleem95 @ansaritalha @merajali294 @syedimran22