Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Feature Module the Bullet points are not aligned correctly #2554

Closed
mdkaleem95 opened this issue Sep 19, 2018 · 8 comments
Closed

In Feature Module the Bullet points are not aligned correctly #2554

mdkaleem95 opened this issue Sep 19, 2018 · 8 comments
Assignees
@MARQAS @syedimran22
Labels
bug
Milestone
Wave

Comments

@mdkaleem95
Copy link

In Feature Module the Bullet points are not aligned correctly it stays at center when we select the left and right Align. Hence Right and left alignment is not working.

Ref: https://secure.helpscout.net/conversation/662236063/34119?folderId=1914712

Screenshot: http://take.ms/JkGld
@Zabi09 Zabi09 added this to the W15 milestone Sep 19, 2018
@Zabi09 Zabi09 added the bug label Sep 19, 2018
raju-jeelaga added a commit that referenced this issue Sep 28, 2018
@raju-jeelaga
#2554 Feature module content alignment option is connected to option …
772c9aa 
…panel

#2554 Feature module content alignment option is connected to option
panel
@MohammedKaludi
Copy link
Collaborator

make the text translatable

772c9aa#diff-78bca971084f2523b6a9248029945ccfR122

@ahmedkaludi ahmedkaludi modified the milestones: W15, Wave Feb 8, 2019
Zabi09 added a commit that referenced this issue Feb 8, 2019
@Zabi09
#2554 translation added
baa2677
@pegazee
Copy link
Contributor

pegazee commented Feb 27, 2019 •
edited by mdkaleem95

** Review **

  • Kaleem

  • imran

@mdkaleem95
Copy link
Author

the Issue still persists in the Swift theme Beta version: http://take.ms/irRKx
and on other 1,2 &3 designs Feature module loads twice

@mdkaleem95 mdkaleem95 removed their assignment Mar 16, 2019
@Zabi09 Zabi09 assigned raju-jeelaga and unassigned Zabi09 and syedimran22 Mar 19, 2019
@raju-jeelaga
Copy link
Contributor

raju-jeelaga commented Mar 25, 2019 •
edited by MARQAS

  • According to design, list of items bullet points are showing and that is correct way that is coming, and we are providing the alignment options in the page builder for list of items, so with that option we can align it.

  • Page builder Modules are Repeating twice in Design 1,2 and 3, and this problem is showing in Beta only, Master Branch it is working fine in all the Designs,
    Please check the screenshot in Beta https://monosnap.com/file/xgcy5IDFog5yhHr7EcgN3VpZi2FzVB

@MARQAS @Zabi09

@raju-jeelaga raju-jeelaga assigned MARQAS and Zabi09 and unassigned raju-jeelaga Mar 25, 2019
raju-jeelaga added a commit that referenced this issue Mar 25, 2019
@raju-jeelaga
#2554 Feature Module the Bullet points properly aligned in Design 1,2…
468b7c4 
… and 3

#2554 Feature Module the Bullet points properly aligned in Design 1,2 and 3
@MARQAS
Copy link
Contributor

MARQAS commented Apr 19, 2019

The double content issue was due to improvements made in #2873

MARQAS added a commit that referenced this issue Apr 19, 2019
@MARQAS
#2554 #2873 To resolve double content issue when Pagebuilder is active
1edc9a9
@pegazee
Copy link
Contributor

pegazee commented Apr 22, 2019 •
edited by mdkaleem95

** Review **

  • Kaleem

  • Imran

@mdkaleem95 mdkaleem95 removed their assignment Apr 22, 2019
@ahmedkaludi ahmedkaludi removed the Sprint label May 8, 2019
@MohammedKaludi
Copy link
Collaborator

👍 ready to merge.

MARQAS added a commit that referenced this issue May 24, 2019
@MARQAS
#2554 Added in master
3abb0c3
@MohammedKaludi
Copy link
Collaborator

Pushed in 0.9.97.55

@MohammedKaludi MohammedKaludi removed this from Bugs in Development Roadmap May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MARQAS MARQAS

@syedimran22 syedimran22

Labels
bug
Projects
None yet
Milestone
Wave
Development

No branches or pull requests
8 participants
@MARQAS @ahmedkaludi @MohammedKaludi @raju-jeelaga @pegazee @Zabi09 @mdkaleem95 @syedimran22