Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightbox feature for Gallery Slider to be built for Slider module #2646

Closed
merajali294 opened this issue Oct 26, 2018 · 6 comments
Closed

Lightbox feature for Gallery Slider to be built for Slider module #2646

merajali294 opened this issue Oct 26, 2018 · 6 comments
Assignees
@pegazee
Labels
feature
Projects
Development Roadmap
Milestone
Wave

Comments

@merajali294
Copy link
Contributor

Reference:

https://secure.helpscout.net/conversation/689629142/37985?folderId=2090438

User requested a feature to add this in our next update.
@Zabi09 Zabi09 added the feature label Oct 26, 2018
@Zabi09 Zabi09 added this to the W15 milestone Oct 26, 2018
@ahmedkaludi ahmedkaludi modified the milestones: W15, Wave Feb 15, 2019
@pegazee
Copy link
Contributor

pegazee commented Feb 28, 2019 •
edited

Already fixed in #2731

Need to discuss this ticket with @MohammedKaludi

@ahmedkaludi ahmedkaludi changed the title Lightbox feature for Gallery Slider to be built. Lightbox feature for Gallery Slider to be built for Slider module Mar 1, 2019
pegazee added a commit that referenced this issue Mar 1, 2019
@pegazee
#2646 lighbox for gallery module in PB added
0c93f46
@pegazee pegazee self-assigned this Mar 1, 2019
@Zabi09
Copy link
Contributor

Zabi09 commented Mar 4, 2019

Escaping is required

pegazee added a commit that referenced this issue Mar 5, 2019
@pegazee
#2646 escaping added
d4156fb
pegazee added a commit that referenced this issue Mar 5, 2019
@pegazee
#2646 condition improved
33bd5b3
@Zabi09
Copy link
Contributor

Zabi09 commented Mar 6, 2019

Lightbox is working after disabling the option also

@pegazee pegazee added the failed label Mar 13, 2019
pegazee added a commit that referenced this issue Mar 13, 2019
@pegazee
#2646 option condition improved
47a24ed
@pegazee
Copy link
Contributor

pegazee commented Apr 3, 2019 •
edited by syedimran22

** review **

  • Kaleem

  • Imran

@mdkaleem95 mdkaleem95 removed their assignment Apr 3, 2019
@syedimran22 syedimran22 removed their assignment Apr 4, 2019
@MohammedKaludi
Copy link
Collaborator

👍 ready to push

@ahmedkaludi ahmedkaludi removed the Sprint label May 8, 2019
pegazee added a commit that referenced this issue May 25, 2019
@pegazee
#2646 Added in master
16eadbb
@ahmedkaludi ahmedkaludi added this to Improvements in Development Roadmap May 27, 2019
@MohammedKaludi
Copy link
Collaborator

Pushed in 0.9.97.55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pegazee pegazee

Labels
feature
Projects
Development Roadmap
Improvements
Milestone
Wave
Development

No branches or pull requests
7 participants
@ahmedkaludi @MohammedKaludi @pegazee @Zabi09 @mdkaleem95 @merajali294 @syedimran22