Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facebook like button is not aligned at the same level with other button. #2811

Closed
pegazee opened this issue Jan 14, 2019 · 6 comments
Closed

Facebook like button is not aligned at the same level with other button. #2811

pegazee opened this issue Jan 14, 2019 · 6 comments
Assignees
@Zabi09
Labels
bug
Milestone
Wave

Comments

@pegazee
Copy link
Contributor

pegazee commented Jan 14, 2019

ref: https://wordpress.org/support/topic/social-share-button-2/

Screenshots:

https://i.imgur.com/bOIPZh3.jpg
https://monosnap.com/file/W6GLWNPMBp1ranun1O86TUCUHRFlHs
@ahmedkaludi ahmedkaludi added this to the Wave milestone Jan 15, 2019
Zabi09 added a commit that referenced this issue Jan 16, 2019
@Zabi09
#2811 facebook like button properly added
63be8e2
@Zabi09 Zabi09 added the bug label Jan 16, 2019
@MARQAS
Copy link
Contributor

MARQAS commented Jan 17, 2019

@Zabi09, please correct it in other designs as well.

Zabi09 added a commit that referenced this issue Jan 17, 2019
@Zabi09
#2811 facebook like button proper alignment added for design 3
be27abe
Zabi09 added a commit that referenced this issue Jan 19, 2019
@Zabi09
#2811 proper function added
04adcd4
@pegazee
Copy link
Contributor Author

pegazee commented Jan 23, 2019 •
edited by syedimran22

** Review **

  • Kaleem

  • Imran

@mdkaleem95
Copy link

Icons are not displaying when selecting single sidebar (left side)

also, the Comment button text color disappear: http://take.ms/WAXIQ

@mdkaleem95 mdkaleem95 removed their assignment Jan 25, 2019
@syedimran22 syedimran22 removed their assignment Jan 28, 2019
@mdkaleem95
Copy link

Working perfectly on Single sidebar as well.

@MohammedKaludi
Copy link
Collaborator

MohammedKaludi commented Jan 30, 2019 •
edited

Icons are not displaying when selecting single sidebar (left side)

@beingsmart3 and what about the icons misalignment below author box?

@MohammedKaludi
Copy link
Collaborator

👍

This was due to another ticket, Order of Elements(#2051). Reverted that code and now its working as expected.

Icons are not displaying when selecting single sidebar (left side)

@beingsmart3 and what about the icons misalignment below author box?

@MohammedKaludi MohammedKaludi reopened this Feb 1, 2019
@pegazee pegazee closed this as completed Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zabi09 Zabi09

Labels
bug
Projects
None yet
Milestone
Wave
Development

No branches or pull requests
7 participants
@MARQAS @ahmedkaludi @MohammedKaludi @pegazee @Zabi09 @mdkaleem95 @syedimran22