Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noreferrer is getting added automatically, it should have what ever the user passes. #3566

Closed
ahmedkaludi opened this issue Aug 20, 2019 · 3 comments
Closed

noreferrer is getting added automatically, it should have what ever the user passes. #3566

ahmedkaludi opened this issue Aug 20, 2019 · 3 comments
Assignees
@santosh8793
Labels
bug [Priority: HIGH]
Milestone
Deployment milestone

Comments

@ahmedkaludi
Copy link
Owner

To recreate, add the below content
<a href="https://google.com" rel="nofollow">Vous voudriez vous ouvrir un peu plus aux autres ? Ou bien développer vos compétences</a> sociales ? Si c'est le cas, vous devez d'abord apprendre à être plus conscient(e) de votre image personnelle.

in the output, you will see noreferrer with the nofollow as well, see: https://monosnap.com/file/tOV2nC8hClzVgGBsH4PfsfUShMyF2E

REF: https://wordpress.org/support/topic/relnoreferrer-issue-in-affiliate-link-in-amp-for-wp/#post-11841642
@ahmedkaludi ahmedkaludi added this to the Next milestone Aug 21, 2019
@ahmedkaludi ahmedkaludi added this to Critical Issues in Development Roadmap Aug 21, 2019
@santosh8793 santosh8793 self-assigned this Aug 21, 2019
santosh8793 added a commit that referenced this issue Aug 21, 2019
@santosh8793
#3566 removed noreferrer code
9436a25
@sonaliramteke sonaliramteke removed their assignment Aug 23, 2019
@MohammedKaludi
Copy link
Collaborator

Ready to merge.

santosh8793 added a commit that referenced this issue Aug 23, 2019
@santosh8793
#3566 Removed code to avoid modification of rel attribute
23fe039
@MohammedKaludi
Copy link
Collaborator

Ready to push.

@Zabi09
Copy link
Contributor

Zabi09 commented Aug 27, 2019

Pushed in 0.9.98.5

@Zabi09 Zabi09 closed this as completed Aug 27, 2019
@Zabi09 Zabi09 removed this from Critical Issues in Development Roadmap Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@santosh8793 santosh8793

Labels
bug [Priority: HIGH]
Projects
None yet
Milestone
Deployment milestone
Development

No branches or pull requests
5 participants
@ahmedkaludi @MohammedKaludi @Zabi09 @santosh8793 @sonaliramteke