New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.9.33 #401
0.9.33 #401
Conversation
Disable comment button when comments are disable #393
To delete all Visual Composet shortcodes
To solve metadata img issues
add preconnect
Hi @khaledMohammed000 @ahmedkaludi @MohammedKaludi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using better code to render VC code, this code is not required.
Please remove the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea to give a default value for SD.
I think this code need to be tested to not deal whit shortcodes in a one by one basis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Lofesa
I have gone through https://css-tricks.com/prefetching-preloading-prebrowsing/
We have internally decided to go with "prefetch" instead of both "preconnect" and "dns-prefetch", reason being caching stuff before they are used has more benefits on performance than other options 👍
Is not a trivial change. Prefechting the sub-resources must be done at each one not in a general call like the preconnect. Example;
and not all those sub-resources are used on all AMP pages. When you know what js files must be used need to print the link rel in head and script call in body. |
Changed the Disable comment button when comments are disable #393 |
Hi @khaledMohammed000 |
@khaledMohammed000 @ahmedkaludi @MohammedKaludi If you consider these changes, can be merged