Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility Issue #3

Closed
AkshayChordiya opened this issue Jul 6, 2015 · 4 comments
Closed

Compatibility Issue #3

AkshayChordiya opened this issue Jul 6, 2015 · 4 comments

Comments

@AkshayChordiya
Copy link

Hi,

I love this library, thank you so much for implement it.
I can understand that Thumb of SeekBar required API 16 & up. Yet can you make this library compliant from API 14 & up.
I mean can I just skip calling setThumbColor methods from my app for API < 16.

I hope we can make it backward compatibility.

EDIT: I checked the source & I guess we can easily make it backward compatible, just need to put API condition. Let me know if you need my help

@ahmedrizwan
Copy link
Owner

Thank you for your feedback. :)
And yes, I'll try and make it compatible. It might take me a few days, but I would want to make it consistent on all the APIs that it supports.

Temporarily, I'll add your suggestion to the source code available on GitHub. But then you'll have to download the lib source, and add dependency manually. (Until I come up with a better solution in the upcoming release)

@AkshayChordiya
Copy link
Author

I don't want to keep the backward compatibility exactly. Just want to make this library compatible with API 14 by skipping the Thumb on it while API > 16 can have the original functionality.
BTW @ahmedrizwan Thanks for reply.

@ahmedrizwan
Copy link
Owner

No problem Akshay :) - Apologies for the late response but I was working on fixing issues and making the Lib compatible with API 14. Well that is done now, it is now fully compatible with API 14 - and is consistent through out all the APIs it supports - upgrade to version 0.2.0 to get the latest update.
For further info - check out the ReadMe. Thanks!

@AkshayChordiya
Copy link
Author

Thank you so much.
I'm so glad.

On Thu, Jul 9, 2015, 7:11 AM ahmed notifications@github.com wrote:

Closed #3 #3.


Reply to this email directly or view it on GitHub
#3 (comment).

Regards,
Akshay Chordiya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants