Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed gem loading error #1

Closed
wants to merge 2 commits into from
Closed

Conversation

naveed-ahmad
Copy link
Contributor

Requiring lib directory could break the main projects.

autoload :GameScreenshotRepresenter, 'igdb/representers/game_screenshot_representer'
autoload :GameThemeRepresenter, 'igdb/representers/game_theme_representer'
autoload :GameVideoRepresenter, 'igdb/representers/game_video_representer'
autoload :PersonRepresenter, 'igdb/representers/person_representer'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@@ -1,4 +1,4 @@
module PersonRepresenter
module Igdb::PersonRepresenter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use nested module/class definitions instead of compact style.

@@ -1,4 +1,4 @@
module GameGenreRepresenter
module Igdb::GameGenreRepresenter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use nested module/class definitions instead of compact style.

@naveed-ahmad
Copy link
Contributor Author

Sorry looks like I've introduced new bugs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants