Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.0.25 Introduces Breaking Changes #40

Closed
maddox opened this issue Feb 23, 2015 · 2 comments
Closed

0.0.25 Introduces Breaking Changes #40

maddox opened this issue Feb 23, 2015 · 2 comments

Comments

@maddox
Copy link

maddox commented Feb 23, 2015

I understand that this gem isn't maintained anymore, but I implore you to reject the 0.0.25 published gem, and replace it with a 0.1.0 version.

The reason is that 0.0.25 introduces a huge breaking change with the API by removing hashuger thus changing the api from:

@movie.backdrops

to

@movie['backdrops']

Bundler has a certain expectation that it can bump the patch version of a gem without expecting any major changes. Most developers have this expectation as well and regularly update their gems this way. By doing this, this would install a version of this gem that would have serious compatibility consequences. If it were 0.1.0, it would not get installed without direct effort by the developer.

Again, I understand that this gem has become unmaintained, but bumping it to a 0.1.0 before doing this would be, in my opinion, a more responsible thing to do.

@ahmetabdi
Copy link
Owner

I understand that this could cause problems for people so I've yanked the 0.0.25 gem from rubygems and have pushed a version 0.1.0 thank you! My knowledge of when to update patch versions has improved :)

@maddox
Copy link
Author

maddox commented Feb 23, 2015

👍👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants