Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fileName with non-ASCII char error : https://github.com/ahmetone… #184

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

zj1123581321
Copy link
Contributor

upload fileName with non-ASCII char. will cause error · Issue #91 · ahmetoner/whisper-asr-webservice


This error is caused by the fact that the key-value pairs in the HTTP header must be encoded using the ASCII character set. In your code, the value of the Content-Disposition header contains non-ASCII characters (Chinese characters), thus causing this error.

To fix this problem, you can properly encode values ​​containing non-ASCII characters. In this case, you can use the urllib.parse.quote method to URL-encode the filename to ensure it contains only ASCII characters. The encoded filename is then used as the value of the Content-Disposition header.

Here is the modified code example:

from urllib.parse import quote

#...

return StreamingResponse(
     result,
     media_type="text/plain",
     headers={
         'Asr-Engine': ASR_ENGINE,
         'Content-Disposition': f'attachment; filename="{quote(audio_file.filename)}.{output}"'
     }
)

By URL-encoding the file name using the quote method, you can ensure that the generated value contains only ASCII characters, thus avoiding errors. In this way, no matter whether the file name contains Chinese characters or not, it can be processed normally.

@ahmetoner ahmetoner merged commit be0beb0 into ahmetoner:main Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants