Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional param to skip the encoding step #82

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

ayancey
Copy link
Sponsor Collaborator

@ayancey ayancey commented Mar 6, 2023

Adds a new encode parameter to asr and detect-language endpoints, which when set to false, skips the ffmpeg encoding process and sends the file directly to whisper. I implemented this to avoid the #42 M4A/MP4 issue which occurs when trying to stream the input file. The simplest way to solve this was to encode on the client-side and send that directly to the ASR.

@ahmetoner
Copy link
Owner

Thanks for your contribution, I will merge it soon.

@blundercode
Copy link

Would also appreciate this merged and fixed.

@ahmetoner ahmetoner merged commit 95c3eed into ahmetoner:main Apr 16, 2023
@ahmetoner
Copy link
Owner

ahmetoner commented Apr 16, 2023

closes #42 #83 #84

This was referenced Apr 16, 2023
@ayancey
Copy link
Sponsor Collaborator Author

ayancey commented Apr 16, 2023

just a reminder to build and push a new docker image when you get the chance

@ahmetoner
Copy link
Owner

We will have a new release with other features in a couple hours.

@blundercode
Copy link

@ahmetoner Thanks for merging the changes really appreciate it! Love the project!

Just curious do you know when the latest version 1.1.0 will be on the dockerhub?

@ahmetoner
Copy link
Owner

@blundercode, new version v1.1.0 has been released on docker hub.

@blundercode
Copy link

@ahmetoner awesome you rock!

Is there anywhere to donate? I really like the project and think it's super helpful and would like to donate if possible.

@ahmetoner
Copy link
Owner

@ahmetoner awesome you rock!

Is there anywhere to donate? I really like the project and think it's super helpful and would like to donate if possible.

@blundercode, you can use my sponsor page. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants