Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to include all subtitles #34

Closed
ahnooie opened this issue Jan 3, 2017 · 3 comments
Closed

Option to include all subtitles #34

ahnooie opened this issue Jan 3, 2017 · 3 comments
Labels
enhancement New feature request/PR

Comments

@ahnooie
Copy link
Member

ahnooie commented Jan 3, 2017

Option to add all subtitles to the mkv file -- but still make the "forced" one default (not sure if this is even possible).

@ahnooie ahnooie added the enhancement New feature request/PR label Jan 3, 2017
@RandomNinjaAtk
Copy link

RandomNinjaAtk commented Jan 4, 2017

The Pull request for MakeMKV profiles would enable this... You have to customize the "default.mmcp.xml" file profile for selection of audio/subtitles to make it work... Specifically, Line 18 is the line that needs to be modified. I use a custom one like this "-sel:all,+sel:(eng|nolang),+sel:special,-sel:havelossless,+sel:(core|havemulti),-sel:mvcvideo,=100:all,-10:eng,=0:lossless,=1:multi".

This way I have lossless audio, more information on customizing it is here: http://www.makemkv.com/forum2/viewtopic.php?f=10&t=4386

@muckngrind4
Copy link
Collaborator

On the handbrake side, this can be accomplished with my last PR. Looks like @RandomNingaAtk has it covered through MakeMKV.

@ahnooie , I'll let you close this once you've reviews the PRs.

@muckngrind4
Copy link
Collaborator

I think this is resolved with the last couple of PR's. I'll close it. We can reopen if needed.

flammableliquids pushed a commit that referenced this issue Jun 9, 2021
Fix bug with incomplete job.config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request/PR
Projects
None yet
Development

No branches or pull requests

3 participants