fix: custom action name regex + add test

ahochsteger · May 25, 2024 · 0ec5b5c · 0ec5b5c
1 parent 5470741
commit 0ec5b5c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/lib/actions/ActionRegistry.spec.ts b/src/lib/actions/ActionRegistry.spec.ts
@@ -283,6 +283,16 @@ describe("ActionRegistry.registerCustomActions", () => {
       contextType: "proc",
     })
   })
+  it("should ensure proper action naming", () => {
+    expect(() => {
+      actionRegistry.registerCustomActions([
+        {
+          name: "my log",
+          action: (_ctx, args) => args,
+        },
+      ])
+    }).toThrow()
+  })
 })
 
 describe("ActionProvider", () => {

diff --git a/src/lib/actions/ActionRegistry.ts b/src/lib/actions/ActionRegistry.ts
@@ -86,7 +86,7 @@ export class ActionRegistry {
   }
 
   public registerCustomActions(actions: ActionRegistration[]) {
-    const nameRegex = "[a-zA-Z0-9]+"
+    const nameRegex = "^[a-zA-Z0-9]+$"
     const regex = new RegExp(nameRegex)
     actions.forEach((customAction) => {
       if (regex.test(customAction.name)) {