Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DeprecationWarning #137

Closed
vltr opened this issue Oct 25, 2018 · 3 comments
Closed

Fix DeprecationWarning #137

vltr opened this issue Oct 25, 2018 · 3 comments
Labels
good for first timers help wanted

Comments

@vltr
Copy link
Collaborator

vltr commented Oct 25, 2018

During tests execution, a DeprecationWarning is given for pyjwt method decode:

  DeprecationWarning
/home/richard/projects/sanic-jwt/.tox/py37/lib/python3.7/site-packages/jwt/api_jws.py:146: DeprecationWarning: It is strongly recommended that you pass in a value for the "algorithms" argument when calling decode(). This argument will be mandatory in a future version.

We have to deal with this in a future release.
@vltr vltr changed the title Fix DeprecationWarning Fix DeprecationWarning Oct 25, 2018
@ahopkins
Copy link
Owner

I believe HS256 is the default, so we should stick with that to not break compatibility.

@ahopkins
Copy link
Owner

This is a much easier one to fix than I originally thought ...

The issue is that there are tests that call jwt.decode directly and not inside sanic_jwt. The tests need to be fixed.

Easy PR for anyone that wants to jump in.

@ahopkins ahopkins mentioned this issue Mar 20, 2019
Merged
@ahopkins
Copy link
Owner

Thanks to @amor71, this can close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good for first timers help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahopkins @vltr