-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add samesite cookie option (fixes #212) #213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. This is a good add. Thank you.
I didn't check the problems with the tests, but run |
The build failed because I forked the |
Yikes. I better go check that out then. |
Still, I ran $ make black
black ./ -l 79 --safe
reformatted /home/lucas/sanic-jwt/setup.py
reformatted /home/lucas/sanic-jwt/sanic_jwt/configuration.py
reformatted /home/lucas/sanic-jwt/sanic_jwt/authentication.py
reformatted /home/lucas/sanic-jwt/tests/conftest.py
reformatted /home/lucas/sanic-jwt/tests/test_configuration.py
reformatted /home/lucas/sanic-jwt/tests/test_claims.py
reformatted /home/lucas/sanic-jwt/tests/test_endpoints_cbv.py
reformatted /home/lucas/sanic-jwt/tests/test_endpoints_basic.py
reformatted /home/lucas/sanic-jwt/tests/test_endpoints_init_on_bp_single.py
reformatted /home/lucas/sanic-jwt/tests/test_exceptions.py
reformatted /home/lucas/sanic-jwt/tests/test_user_secret.py
All done! ✨ 🍰 ✨
11 files reformatted, 69 files left unchanged. And of the 4 files that I changed in this PR, only |
Regarding the tests, I did modify |
While not urgent. I am curious about the status of this as I'd like to get rid of the samesite cookie warnings if possible |
Let's get the tests passing and then merge/release. |
Sadly, I can't do anything about the Travis build failing. |
Working on it |
@ahopkins Thanks for getting this merged! |
Fixes #212