Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat 21.3 #214

Merged
merged 6 commits into from
Aug 12, 2021
Merged

Compat 21.3 #214

merged 6 commits into from
Aug 12, 2021

Conversation

ahopkins
Copy link
Owner

@ahopkins ahopkins commented Apr 4, 2021

Resolves #211

Adds 21.3 support, and also adds a check to throw a runtime warning if you do not set the secret.

@ahopkins ahopkins requested a review from vltr April 4, 2021 18:44
@codecov
Copy link

codecov bot commented Apr 4, 2021

Codecov Report

Merging #214 (86f66e6) into main (6b719b1) will decrease coverage by 0.14%.
The diff coverage is 92.85%.

❗ Current head 86f66e6 differs from pull request most recent head d714f28. Consider uploading reports for the commit d714f28 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   97.71%   97.57%   -0.15%     
==========================================
  Files          12       13       +1     
  Lines        1050     1070      +20     
  Branches      174      176       +2     
==========================================
+ Hits         1026     1044      +18     
- Misses         15       16       +1     
- Partials        9       10       +1     
Impacted Files Coverage Δ
sanic_jwt/authentication.py 93.86% <ø> (ø)
sanic_jwt/initialization.py 98.80% <81.81%> (-1.20%) ⬇️
sanic_jwt/__init__.py 100.00% <100.00%> (ø)
sanic_jwt/claim.py 100.00% <100.00%> (ø)
sanic_jwt/configuration.py 99.35% <100.00%> (+<0.01%) ⬆️
sanic_jwt/decorators.py 96.69% <100.00%> (ø)
sanic_jwt/endpoints.py 96.38% <100.00%> (ø)
sanic_jwt/responses.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b719b1...d714f28. Read the comment docs.

@ahopkins ahopkins merged commit dad2f90 into main Aug 12, 2021
@ahopkins ahopkins deleted the compat-21.3 branch August 12, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

instance.auth will not support in the future
1 participant