feat: allow negative integers in validation (#17)

lib/mini_defender/rules/integer.rb

@@ -6,12 +6,14 @@ def self.signature
   end
 
   def coerce(value)
-    value.to_i
+    Integer(value)
   end
 
   def passes?(attribute, value, validator)
-    value.is_a?(Integer) || value.is_a?(String) && value.match?(/^\d+$/)
-  end
+    Integer(value.to_s)
+  rescue
+    false
+  end  
 
   def message(attribute, value, validator)
     "The value must be an integer."

test/rules/integer_test.rb

@@ -3,5 +3,39 @@
 require 'test_helper'
 
 class IntegerTest < Minitest::Test
+  def setup
+    @rule = MiniDefender::Rules::Integer.new
+  end
 
+  def test_passes_with_string_positive_integer
+    assert(@rule.passes?("test", "10", nil))
+  end
+
+  def test_passes_with_string_negative_integer
+    assert(@rule.passes?("test", "-10", nil))
+  end
+
+  def test_fails_with_float
+    refute(@rule.passes?("test", 10.5, nil))
+  end
+
+  def test_fails_with_string_float
+    refute(@rule.passes?("test", "10.5", nil))
+  end
+
+  def test_fails_with_non_numeric_string
+    refute(@rule.passes?("test", "not a number", nil))
+  end
+
+  def test_fails_with_nil
+    refute(@rule.passes?("test", nil, nil))
+  end
+
+  def test_fails_with_array
+    refute(@rule.passes?("test", [], nil))
+  end
+
+  def test_fails_with_hash
+    refute(@rule.passes?("test", {}, nil))
+  end
 end