Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux compile failure: ‘pdf_parse_link_uri’ was not declared in this scope #804

Closed
parkerlreed opened this issue Aug 29, 2023 · 3 comments

Comments

@parkerlreed
Copy link

Arch Linux
gcc 13.2.1-3
libmupdf 1.23.0-1

      |                                  ^~~~~~~~
In file included from /usr/include/c++/13.2.1/bits/stl_iterator_base_funcs.h:66,
                 from /usr/include/c++/13.2.1/string:47,
                 from /usr/include/c++/13.2.1/bits/locale_classes.h:40,
                 from /usr/include/c++/13.2.1/bits/ios_base.h:41,
                 from /usr/include/c++/13.2.1/ios:44,
                 from /usr/include/c++/13.2.1/ostream:40,
                 from /usr/include/c++/13.2.1/iostream:41,
                 from pdf_viewer/pdf_view_opengl_widget.h:3:
/usr/include/c++/13.2.1/bits/stl_iterator_base_types.h:127:34: note: declared here
  127 |     struct _GLIBCXX17_DEPRECATED iterator
      |                                  ^~~~~~~~
In file included from pdf_viewer/utf8.h:32:
pdf_viewer/utf8/unchecked.h:179:40: warning: ‘template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator’ is deprecated [-Wdeprecated-declarations]
  179 |           class iterator : public std::iterator <std::bidirectional_iterator_tag, uint32_t> {
      |                                        ^~~~~~~~
/usr/include/c++/13.2.1/bits/stl_iterator_base_types.h:127:34: note: declared here
  127 |     struct _GLIBCXX17_DEPRECATED iterator
      |                                  ^~~~~~~~
pdf_viewer/utils.cpp: In function ‘ParsedUri parse_uri(fz_context*, std::string)’:
pdf_viewer/utils.cpp:120:29: error: ‘pdf_parse_link_uri’ was not declared in this scope; did you mean ‘pdf_parse_ind_obj’?
  120 |         fz_link_dest dest = pdf_parse_link_uri(mupdf_context, uri.c_str());
      |                             ^~~~~~~~~~~~~~~~~~
      |                             pdf_parse_ind_obj
pdf_viewer/utils.cpp: In function ‘void install_app(const char*)’:
pdf_viewer/utils.cpp:174:30: warning: unused parameter ‘argv0’ [-Wunused-parameter]
  174 | void install_app(const char *argv0)
      |                  ~~~~~~~~~~~~^~~~~
In file included from pdf_viewer/utf8.h:31,
                 from pdf_viewer/utils.h:21,
                 from pdf_viewer/ui.h:41,
                 from pdf_viewer/ui.cpp:1:
pdf_viewer/utf8/checked.h:268:34: warning: ‘template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator’ is deprecated [-Wdeprecated-declarations]
  268 |     class iterator : public std::iterator <std::bidirectional_iterator_tag, uint32_t> {
      |                                  ^~~~~~~~
In file included from /usr/include/c++/13.2.1/bits/stl_iterator_base_funcs.h:66,
                 from /usr/include/c++/13.2.1/string:47,
                 from pdf_viewer/ui.h:2:
/usr/include/c++/13.2.1/bits/stl_iterator_base_types.h:127:34: note: declared here
  127 |     struct _GLIBCXX17_DEPRECATED iterator
      |                                  ^~~~~~~~
In file included from pdf_viewer/utf8.h:32:
pdf_viewer/utf8/unchecked.h:179:40: warning: ‘template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator’ is deprecated [-Wdeprecated-declarations]
  179 |           class iterator : public std::iterator <std::bidirectional_iterator_tag, uint32_t> {
      |                                        ^~~~~~~~
/usr/include/c++/13.2.1/bits/stl_iterator_base_types.h:127:34: note: declared here
  127 |     struct _GLIBCXX17_DEPRECATED iterator
@marsam
Copy link

marsam commented Aug 29, 2023

FWIW Alpine Linux has a patch to fix the build with mupdf-0.23.0 https://git.alpinelinux.org/aports/tree/community/sioyek/mupdf-0.23.0.patch?id=86e913eccf19b97a16f25d9b6cdf0f50232f1226

@xyven1
Copy link

xyven1 commented Nov 27, 2023

Is there a patch for a more recent commit?

freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue Jan 4, 2024
 - mupdf 0.23 dropped a symbol we need; apply a Debian patch to not
   require it
 - unbundle synctex

See also:	ahrm/sioyek#804
Obtained from:	https://salsa.debian.org/viccie30/sioyek/-/blob/debian/latest/debian/patches/0007-fix-build-with-mupdf-0.23.0.patch
MFH:		2024Q1
@ahrm
Copy link
Owner

ahrm commented Jan 23, 2024

This is fixed in the development branch here: https://github.com/ahrm/sioyek/tree/development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants