Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to mupdf 1.20 #294

Closed
wants to merge 2 commits into from
Closed

Upgrade to mupdf 1.20 #294

wants to merge 2 commits into from

Conversation

hrdl-github
Copy link
Contributor

mupdf 1.20 makes some changes that affect sioyek: https://git.ghostscript.com/?p=mupdf.git;a=commit;h=b8102094a8996f49223fde76c5821b9945ca4198
I will use these modifications and see if anything else breaks.

@ahrm
Copy link
Owner

ahrm commented Jun 29, 2022

It is unlikely that I upgrade mupdf (because it may break builds and is a headache in general) unless there is a very good reason to do so (e.g. significantly improved performance, new file type support). For now 1.20 release doesn't look very interesting to me.

@ahrm ahrm closed this Jun 29, 2022
@DhruvaSambrani
Copy link
Contributor

Hi @ahrm I understand your view, but if builds can be made sure to not break, then would you be ok with updating? The AUR build passes but runtime error is thrown due to package-header mismatch.

@ahrm
Copy link
Owner

ahrm commented Jul 11, 2022

I mean I don't have any problems with upgrading if it doesn't create any problems, I just don't think it is the correct solution. I am not very familiar with linux packaging so correct me if I am wrong but does archlinux expect everyone to use version 1.20 because they are using it? What if another distribution comes along and expects us to use the version that they are using? (and this is not a hypothetical question, for example Ubuntu 18.04 LTS uses version 1.16 and 20.04 LTS uses 1.18)? What if yet another distribution comes along that uses 1.21? Are we supposed to maintain 5 different versions of source code to keep everybody happy?

To me, the sane solution to the problem seems to be to include the source code of the version that we are using in the repository and build against exactly that version (which is what we already do).

@goggle
Copy link
Contributor

goggle commented Jul 13, 2022

@ahrm Arch Linux is a "rolling release" distribution that generally has the latest stable releases of software in their repositories. This means that their mupdf currently is at version 1.20. It would be nice to always support the latest stable release of mupdf, but I also totally understand your point. I'm not aware of the release cycle of mupdf, but maybe it is enough to support the most recent or the two most recent versions of mupdf, so that distributions that ship an older version of mupdf can simply backport the breaking changes for the current stable release of sioyek.

I have managed to get a working AUR package for sioyek 1.4.0 by including this PR as a patch: https://aur.archlinux.org/packages/sioyek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants