fix: error readable by using the right placeholder (runfinch#39)

*Description of changes:*

Logs aren't as readable as they could be, I saw this during `finch vm
init`:

```
INFO[0009] sudoers file not found: %!w(*fs.PathError=&{open /etc/sudoers.d/finch-lima 2})
```

From the looks of it, we don't need the `%w` since the current logging
implementation doesn't use `fmt.Errorf` under the hood anyway, and thus
makes the output hard to read without the only potential benefit being
utilised (unwrapping). And since the logging interface's methods
themselves don't return anything, it's fairly likely unwrapping won't
happen in any other implementation (there isn't even a reason for it
anyway - the callee will have all the args available to it, so it can
introspect the error passed directly).

(Since this `Infof` call is made right after an `errors.Is`, the whole
`%v`/`%w` bit is redundant as it will just say "sudoers file not found:
no such file or directory", but I didn't want to change error semantics
in this PR.)


*Testing done:*

`make test-unit` and using `logrus` directly to verify none of its `*f`
methods use `fmt.Errorf`.


- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Ondrej Kokes <ondrej.kokes@gmail.com>
Co-authored-by: Weike Qu <47606630+weikequ@users.noreply.github.com>

pkg/dependency/vmnet/binaries.go

@@ -66,7 +66,7 @@ func (bin *binaries) buildArtifactSocketVmnetExe() string {
 func (bin *binaries) Installed() bool {
 	dirExists, err := afero.DirExists(bin.fs, bin.installationPath())
 	if err != nil {
-		bin.l.Errorf("failed to get status of binaries directory: %w", err)
+		bin.l.Errorf("failed to get status of binaries directory: %v", err)
 		return false
 	}
 	if !dirExists {
@@ -76,18 +76,18 @@ func (bin *binaries) Installed() bool {
 	buildArtifactFileBytes, err := afero.ReadFile(bin.fs, bin.buildArtifactSocketVmnetExe())
 	if err != nil {
 		if errors.Is(err, fs.ErrNotExist) {
-			bin.l.Infof("dependency socket_vmnet file not found: %w", err)
+			bin.l.Infof("dependency socket_vmnet file not found: %v", err)
 		} else {
-			bin.l.Errorf("failed to read dependency socket_vmnet file: %w", err)
+			bin.l.Errorf("failed to read dependency socket_vmnet file: %v", err)
 		}
 		return false
 	}
 	installedFileBytes, err := afero.ReadFile(bin.fs, bin.installationPathSocketVmnetExe())
 	if err != nil {
 		if errors.Is(err, fs.ErrNotExist) {
-			bin.l.Infof("installed socket_vmnet file not found: %w", err)
+			bin.l.Infof("installed socket_vmnet file not found: %v", err)
 		} else {
-			bin.l.Errorf("failed to read installed socket_vmnet file: %w", err)
+			bin.l.Errorf("failed to read installed socket_vmnet file: %v", err)
 		}
 		return false
 	}

pkg/dependency/vmnet/binaries_test.go

@@ -106,7 +106,7 @@ func TestBinaries_Installed(t *testing.T) {
 				pathErr.Path = "mock_prefix/dependencies/lima-socket_vmnet/opt/finch/bin/socket_vmnet"
 				pathErr.Err = errors.New("file does not exist")
 
-				l.EXPECT().Infof("dependency socket_vmnet file not found: %w", &pathErr)
+				l.EXPECT().Infof("dependency socket_vmnet file not found: %v", &pathErr)
 			},
 			want: false,
 		},
@@ -125,7 +125,7 @@ func TestBinaries_Installed(t *testing.T) {
 				pathErr.Path = "/opt/finch/bin/socket_vmnet"
 				pathErr.Err = errors.New("file does not exist")
 
-				l.EXPECT().Infof("installed socket_vmnet file not found: %w", &pathErr)
+				l.EXPECT().Infof("installed socket_vmnet file not found: %v", &pathErr)
 			},
 			want: false,
 		},

pkg/dependency/vmnet/sudoers_file.go

@@ -44,16 +44,16 @@ func (s *sudoersFile) Installed() bool {
 	b, err := afero.ReadFile(s.fs, s.path())
 	if err != nil {
 		if errors.Is(err, fs.ErrNotExist) {
-			s.l.Infof("sudoers file not found: %w", err)
+			s.l.Infof("sudoers file not found: %v", err)
 		} else {
-			s.l.Errorf("failed to read sudoers file: %w", err)
+			s.l.Errorf("failed to read sudoers file: %v", err)
 		}
 		return false
 	}
 	cmd := s.limaCmdCreator.CreateWithoutStdio("sudoers")
 	out, err := cmd.Output()
 	if err != nil {
-		s.l.Errorf("failed to run lima sudoers command: %w", err)
+		s.l.Errorf("failed to run lima sudoers command: %v", err)
 		return false
 	}
 	return bytes.Equal(b, out)

pkg/dependency/vmnet/sudoers_file_test.go

@@ -58,7 +58,7 @@ func TestSudoers_Installed(t *testing.T) {
 				pathErr.Path = "/etc/sudoers.d/finch-lima"
 				pathErr.Err = errors.New("file does not exist")
 
-				l.EXPECT().Infof("sudoers file not found: %w", &pathErr)
+				l.EXPECT().Infof("sudoers file not found: %v", &pathErr)
 			},
 			want: false,
 		},
@@ -73,7 +73,7 @@ func TestSudoers_Installed(t *testing.T) {
 
 				lc.EXPECT().CreateWithoutStdio("sudoers").Return(cmd)
 				cmd.EXPECT().Output().Return([]byte{}, wantErr)
-				l.EXPECT().Errorf("failed to run lima sudoers command: %w", wantErr)
+				l.EXPECT().Errorf("failed to run lima sudoers command: %v", wantErr)
 			},
 			want: false,
 		},

pkg/dependency/vmnet/update_override_lima_config.go

@@ -62,16 +62,16 @@ func (overConf *overrideLimaConfig) verifyConfigHasNetworkSection(filePath strin
 	yamlFile, err := afero.ReadFile(overConf.fs, filePath)
 	if err != nil {
 		if errors.Is(err, fs.ErrNotExist) {
-			overConf.l.Debugf("config file not found: %w", err)
+			overConf.l.Debugf("config file not found: %v", err)
 		} else {
-			overConf.l.Errorf("failed to read config file: %w", err)
+			overConf.l.Errorf("failed to read config file: %v", err)
 		}
 		return false
 	}
 	var cfg NetworkConfig
 	err = yaml.Unmarshal(yamlFile, &cfg)
 	if err != nil {
-		overConf.l.Errorf("failed to unmarshal YAML from override config file: %w", err)
+		overConf.l.Errorf("failed to unmarshal YAML from override config file: %v", err)
 		return false
 	}
 

pkg/dependency/vmnet/update_override_lima_config_test.go

@@ -46,7 +46,7 @@ func TestOverrideLimaConfig_verifyConfigHasNetworkSection(t *testing.T) {
 				pathErr.Path = "mock_config_file"
 				pathErr.Err = errors.New("file does not exist")
 
-				l.EXPECT().Debugf("config file not found: %w", &pathErr)
+				l.EXPECT().Debugf("config file not found: %v", &pathErr)
 			},
 			want: false,
 		},
@@ -59,7 +59,7 @@ func TestOverrideLimaConfig_verifyConfigHasNetworkSection(t *testing.T) {
 				var typeErr yaml.TypeError
 				typeErr.Errors = []string{"line 1: cannot unmarshal !!str `this is...` into vmnet.NetworkConfig"}
 
-				l.EXPECT().Errorf("failed to unmarshal YAML from override config file: %w", &typeErr)
+				l.EXPECT().Errorf("failed to unmarshal YAML from override config file: %v", &typeErr)
 			},
 			want: false,
 		},