Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internals] File greeks/src /BS_European_Greek_cpp.cpp ? #14

Closed
lrnv opened this issue Oct 30, 2023 · 3 comments
Closed

[internals] File greeks/src /BS_European_Greek_cpp.cpp ? #14

lrnv opened this issue Oct 30, 2023 · 3 comments

Comments

@lrnv
Copy link

lrnv commented Oct 30, 2023

This file is full of commented code. Why ? If this code has nothing to do here, simply remlove it (it still lives in your git history it is not lost).

@ahudde
Copy link
Owner

ahudde commented Oct 31, 2023

Good point, that draft doesn't have a purpose right now, I deleted it. b12788d

@ahudde ahudde closed this as completed Oct 31, 2023
@lrnv
Copy link
Author

lrnv commented Oct 31, 2023

It was a draft for future functionality ? In which case it probably belongs to its own brnach so that you can work on it without having to comment / uncomment it when you make releases.

@ahudde
Copy link
Owner

ahudde commented Oct 31, 2023

That's true, I should do that. In this case, I don't think I will pursue this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants